Add support for column comments - #306
Merged
Merged
Conversation
Signed-off-by: Christophe Bornet <cbornet@hotmail.com>
cbornet
requested review from
andrefurlan-db,
arikfr,
susodapop and
yunbodeng-db
as code owners
December 22, 2023 13:24
cbornet
force-pushed
the
column_comment
branch
from
December 22, 2023 15:56
76ece75 to
7537b93
Compare
Signed-off-by: Christophe Bornet <cbornet@hotmail.com>
cbornet
force-pushed
the
column_comment
branch
from
December 22, 2023 15:57
7537b93 to
bf2f18b
Compare
Author
|
Hi @susodapop, will you have time to review this soon ? |
Contributor
|
Yep! Just getting back up to speed following vacation time away. |
Author
|
Awesome, thanks ! |
susodapop
reviewed
Jan 23, 2024
susodapop
left a comment
susodapop
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this contribution! Looks great. I'm going to push a few test additions. Plus we need an entry in the changelog.
| autoincrement=True on a column. See comments in test_suite.py. We may implement implicit | ||
| IDENTITY using this feature in the future, similar to the Microsoft SQL Server dialect. | ||
| """ | ||
| # Emit a log message if a user attempts to set autoincrement=True on a column. |
Contributor
There was a problem hiding this comment.
Let's keep this as a docstring, since regular comments aren't surfaced in a code editor
added 2 commits
January 23, 2024 14:56
…ressions Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Contributor
|
I've changed the base branch for this PR to a |
susodapop
reviewed
Jan 23, 2024
| "type": final_col_type, | ||
| "nullable": bool(thrift_resp_row.NULLABLE), | ||
| "default": thrift_resp_row.COLUMN_DEF, | ||
| "comment": thrift_resp_row.REMARKS, |
Contributor
There was a problem hiding this comment.
In order to pass the ComponentReflectionTest we need to update this line to
"comment": thrift_resp_row.REMARKS or None
This was referenced Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.