Skip to content

SQLAlchemy 2: implement and refactor schema reflection methods #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susodapop merged 7 commits into from
Oct 13, 2023
Merged

SQLAlchemy 2: implement and refactor schema reflection methods #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ee8a0f2
Immediately skip any tests on temp tables because we don't support them
Oct 12, 2023
3527b04
This commit gets the test_not_existing_table test to pass
Oct 13, 2023
c957e7d
Make test_get_schema_names PASS
Oct 13, 2023
48604ef
Move COLUMN_TYPE_MAP into module so it won't be instantiated on every
Oct 13, 2023
ad8edbc
Refactor dialect's has_table method to extract _describe_table_extended
Oct 13, 2023
e15542f
Refactor primary and foreign key parsing
Oct 13, 2023
bea9f0b
Refactor foreign key parsing completely into the _parse.py file
Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ python -m pytest test_suite.py --dburi \
Some of these of these tests fail currently. We're working on getting relevant tests passing and others skipped. The tests that we've already reviewed and verified
are decorated with a pytest marker called `reviewed`. To only run these tests and check for regressions, you can add `-m reviewed` to the invocation command above.

These tests require two schemas exist in your catalog:
- An empty schema which can have an arbitrary name. It is configured in the SQLAlchemy --dburi
- An empty schema named `test_schema`

### Code formatting

This project uses [Black](https://pypi.org/project/black/).
Expand Down
Loading