Retry attempts that fail due to a connection timeout - #24

Merged

susodapop merged 23 commits into

mainfrom

retry-connection-attempt-failures

Aug 5, 2022

Commits on Jul 28, 2022

Explicitly catch OSError and socket.timeout errors, with automatic retry
susodapop
committed
fa13d75
Add unit and e2e tests for retries on timeout behaviour.
susodapop
committed
b44d0b8
Add default delay to the retry policy
susodapop
committed
22d2ac0
Don't make unit test take 5+ seconds
susodapop
committed
44f12b7
Fix broken unit tests: test_retry_args_bounding
susodapop
committed
09cefec
Black thrift_backend.py
susodapop
committed
de96fce
Only retry OSError's that mention Errno 110
susodapop
committed
21c06d4
Fix unnecessary indentation
susodapop
committed
befdf3d

Commits on Jul 29, 2022

Clarify docstrings after review feedback
susodapop
committed
fb1275b
Default retry_delay = None (not retryable)
susodapop
committed
c76ee65

Commits on Aug 2, 2022

This approach passes the e2e tests, but they take exactly 4 mins 51 secs
susodapop
committed
7474834

Commits on Aug 4, 2022

Revert all changes since `main`
susodapop
committed
fa1fd50
isolate delay bounding
susodapop
committed
bf65b81
Move error details scope up one-level.
susodapop
committed
a0d340e
Retry GetOperationStatus if an OSError was raised during execution
susodapop
committed
a55cf9d
Log when a request is retried due to an OSError.
susodapop
committed
38411a8
Update docstring for make_request
susodapop
committed
5096ef0
Nit: unit tests show the .warn message is deprecated.
susodapop
committed
5c1ee79
Black thrift_backend.py
susodapop
committed
1f87a38
Rerun black on thrift_backend.py
susodapop
committed
baff3d5

Commits on Aug 5, 2022

Add comment about manual tests
susodapop
committed
10016ea
Bump to v2.0.3
susodapop
committed
4db4ad0
Revert "Bump to v2.0.3"
susodapop
committed
767e34c