Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: databricks/databricks-sql-nodejs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: databricks/databricks-sql-nodejs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: kernel-rc-cross-os-ci
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 21 files changed
  • 1 contributor

Commits on Jun 15, 2026

  1. ci: cross-OS bug-bash suite for the kernel (SEA) RC 

    Adds a workflow_dispatch GitHub Actions workflow that runs the kernel
bug-bash suite (useKernel:true) against the published RC
(@databricks/sql@1.16.0-rc.1) across every supported platform, to confirm
the per-platform @databricks/databricks-sql-kernel-<triple> napi binary
installs, loads, and works:

  - linux-x64-gnu (Node 18/20/22), linux-arm64-gnu
  - darwin-x64, darwin-arm64
  - win32-x64-msvc
  - linux-x64-musl / linux-arm64-musl (Alpine via docker)

Vendored under ci/kernel-rc-bugbash/ with its own pinned package.json so it
is isolated from the driver's own build. Reuses the repo's existing e2e
secrets (DATABRICKS_HOST / TEST_PECO_WAREHOUSE_HTTP_PATH / DATABRICKS_TOKEN).
The kernel loader requires Node >= 18, so the matrix omits 14/16.

Workspace/warehouse ids are derived from the host/path so the suite is
portable across warehouses; the SPOG scenario skips when they can't be
derived (non-Azure hosts).

Co-authored-by: Isaac
    @msrathore-db
    msrathore-db committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    f73e65a View commit details
    Browse the repository at this point in the history

  2. ci(kernel-rc-cross-os): add Node 16 validation + push trigger 

    - Add Node 16 to the cross-OS matrix (ubuntu/macos-13/macos-latest/windows).
  The published RC loader gates kernel at >=18; these jobs lower the floor
  18->16 in the installed package to validate the proposed change (kernel on
  Node 16), and additionally run the Thrift suite (no change needed).
- musl: add a node:16-alpine variant alongside node:20-alpine.
- Trigger on push to this branch (+ manual dispatch); default rc 1.16.0-rc.1.
- METRIC_VIEW scenario: treat absence as env-dependent (note, not failure) —
  a metric view only exists if one is defined on the warehouse.

Co-authored-by: Isaac
    @msrathore-db
    msrathore-db committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    9264301 View commit details
    Browse the repository at this point in the history

  3. ci(kernel-rc-cross-os): drop proxy-pinned lockfile so CI resolves fro… 

    …m public npm

The vendored package-lock.json was generated via npm-proxy.dev.databricks.com;
its 126 `resolved` URLs are unreachable from GitHub-hosted runners (same class
of issue as #436). Remove it and gitignore it — the workflow uses `npm install`,
which resolves fresh from the default public registry on CI. The RC is still
deterministic (package.json pins @databricks/sql 1.16.0-rc.1 and the workflow
installs it explicitly).

Co-authored-by: Isaac
    @msrathore-db
    msrathore-db committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    fd88e4d View commit details
    Browse the repository at this point in the history

  4. ci(kernel-rc-cross-os): attach jobs to azure-prod environment for e2e… 

    … secrets

The DATABRICKS_HOST / TEST_PECO_WAREHOUSE_HTTP_PATH / DATABRICKS_TOKEN secrets
are scoped to the azure-prod environment (as in main.yml), not repo-level.
Without 'environment: azure-prod' the jobs saw empty creds and failed at
assertEnv. azure-prod has no protection rules / branch restriction, so
push-triggered runs proceed without approval.

Co-authored-by: Isaac
    @msrathore-db
    msrathore-db committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    ccd2707 View commit details
    Browse the repository at this point in the history

  5. ci(kernel-rc-cross-os): pin actions to full commit SHAs (org policy) 

    databricks org requires all actions pinned to a full-length commit SHA;
actions/checkout@v4 and setup-node@v4 were rejected at 'Set up job'. Pin to
the same SHAs main.yml uses.

Co-authored-by: Isaac
    @msrathore-db
    msrathore-db committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    a0128c9 View commit details
    Browse the repository at this point in the history

  6. ci(kernel-rc-cross-os): force-install kernel binary on Node 16 (npm s… 

    …kips it via engines>=18)

CI proved npm omits the kernel optionalDependencies on Node 16 because they
declare engines>=18, so the binary was never installed (Cannot find module
@databricks/databricks-sql-kernel-*). Direct-install the matching triple
(engines only warns on a direct install) before lowering the loader floor —
demonstrating the FULL proposed change (engines + floor) needed for Node 16.

Co-authored-by: Isaac
    @msrathore-db
    msrathore-db committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    d99a3df View commit details
    Browse the repository at this point in the history

  7. test(concurrency): retry transient server errors in the 80-way concur… 

    …rency check

CI showed the only red across Node 16/18/20/22 was the 'Many concurrent queries'
test hitting server-side transients (sparkSession null / Couldn't create
directory) when many parallel CI jobs blast one shared warehouse — not a driver
bug. Retry those transients (a real app would), keeping the identity assertion.

Co-authored-by: Isaac
    @msrathore-db
    msrathore-db committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    78a2c45 View commit details
    Browse the repository at this point in the history

  8. test(cancel): treat 'could not get query in-flight' as inconclusive, … 

    …not failure

On a contended/fast warehouse the long query occasionally returns already
in a terminal state, so cancel can't be observed. That's an env-timing
inconclusive (cancel not exercised), not a driver bug — retry the submit a
few times, and if still not in-flight, return a note instead of failing.
(Surfaced as the only red on win32-x64-msvc node 16, whose KERNEL run was 40/0/6.)

Co-authored-by: Isaac
    @msrathore-db
    msrathore-db committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    e716506 View commit details
    Browse the repository at this point in the history
Loading