Draft
Conversation
Separate concrete paths from wildcard patterns at the type level: - PathNode: for concrete paths without wildcards (used by Get, Set, Walk) - PatternNode: for patterns that may include wildcards (used by WalkType, Validate) - PathNodeBase: shared struct with common fields and methods Add cleaner parsing API: - ParsePath(s) -> (*PathNode, error) - ParsePattern(s) -> (*PatternNode, error) - MustParsePath(s), MustParsePattern(s) for tests Rename validation functions for consistency: - ValidatePath for PathNode - ValidatePattern for PatternNode Update HasChange to accept *PathNode with precalculated paths. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Collaborator
|
Commit: 26b99a6
31 interesting tests: 14 flaky, 7 KNOWN, 5 SKIP, 5 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Separate concrete paths from wildcard patterns at the type level:
Add cleaner parsing API:
Rename validation functions for consistency:
Update HasChange to accept *PathNode with precalculated paths.
Why
Make it clear where we work with concrete path and where with pattern.