Skip to content

Update dynamic theme fixes for *.sloggi.com and *.triumph.com - #16132

Merged
Myshor merged 3 commits into
darkreader:mainfrom
arturstat:patch-816849
Oct 23, 2026
Merged

Update dynamic theme fixes for *.sloggi.com and *.triumph.com#16132
Myshor merged 3 commits into
darkreader:mainfrom
arturstat:patch-816849

Conversation

@arturstat

@arturstat arturstat commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@arturstat
arturstat marked this pull request as draft October 23, 2026 18:46
arturstat
arturstat commented Oct 23, 2026
View reviewed changes
Comment thread src/config/dynamic-theme-fixes.config Outdated
button.navbar-toggler
div.header__icon svg.svgIcon.svgIcon__menuClose
div.help-content-entry img
span.menuCountrySelector__flag

@arturstat arturstat Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globe icon in "Select a country" > "Other countries" menu at:
https://uk.triumph.com/

Comment thread src/config/dynamic-theme-fixes.config Outdated
div.productTile div.colorDotSwatch--plp {
background: var(--swatch-color) !important;
}
.experience-component * {

@arturstat arturstat Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed as it seems to be unnecessary because white text is already applied by default.
This rule also conflicts with line 1450 above.

@arturstat
arturstat marked this pull request as ready for review October 23, 2026 18:50
@arturstat arturstat mentioned this pull request Oct 23, 2026
Merged
@Myshor
Myshor merged commit 4d80f7c into darkreader:main Oct 23, 2026
1 check passed
@Myshor

Myshor commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Applying invert across .menuCountrySelector__flag breaks the authentic colors of all national flags in the selector.

Instead, setting background-color: white !important; on .menuCountrySelector__flag resolves the visibility of the globe icons under 'Other countries' while preserving all national flag colors, as well as fixing the UK flag background.

I pushed and merged this fix. This concludes my maintenance work in the repository for tonight. Any further items will wait until tomorrow.

@arturstat

arturstat commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

The buttons will need defining the background color.
I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arturstat @Myshor