Add dynamic theme fixes for thrivemagazine.com - #15870
Conversation
| thrivemagazine.com | ||
|
|
||
| INVERT | ||
| div#MENU_AS_CONTAINER_TOGGLE span |
There was a problem hiding this comment.
Hamburguer icon in the mobile version:
https://www.thrivemagazine.com/
| div#MENU_AS_CONTAINER_TOGGLE span | ||
|
|
||
| CSS | ||
| div.wixui-vertical-menu__arrow svg { |
There was a problem hiding this comment.
Up and down arrow icon in the sidepanel:
https://www.thrivemagazine.com/
There was a problem hiding this comment.
Checked in Firefox and Edge... I don't see any need for this entry. Without it I have visible arrow.
There was a problem hiding this comment.
I agree that the arrow is visible.
However, it is still not clear enough for me.
Please see the comment below.
| div.wixui-vertical-menu__arrow svg { | ||
| fill: var(--darkreader-neutral-text) !important; | ||
| } | ||
| nav#MENU_AS_CONTAINER_EXPANDABLE_MENU a { |
There was a problem hiding this comment.
Text in the sidepanel:
https://www.thrivemagazine.com/
There was a problem hiding this comment.
I can not confirm that applying this is needed. I see light text in dark scheme and dark in light scheme without this CSS fix. Checked both Firefox and Edge.
| nav#MENU_AS_CONTAINER_EXPANDABLE_MENU a { | ||
| color: var(--darkreader-neutral-text) !important; | ||
| } | ||
| nav#MENU_AS_CONTAINER_EXPANDABLE_MENU *, |
There was a problem hiding this comment.
Area in the sidepanel that sometimes is green instead of black:
https://www.thrivemagazine.com/
| color: var(--darkreader-neutral-text) !important; | ||
| } | ||
| nav#MENU_AS_CONTAINER_EXPANDABLE_MENU *, | ||
| div#MENU_AS_CONTAINER_TOGGLE > div { |
There was a problem hiding this comment.
Area around the hamburguer icon in the mobile version occasionally showing green:
https://www.thrivemagazine.com/
| div#MENU_AS_CONTAINER_TOGGLE > div { | ||
| background-color: transparent !important; | ||
| } | ||
| div#overlay-MENU_AS_CONTAINER, |
There was a problem hiding this comment.
Area in the sidepanel occasionally showing green:
https://www.thrivemagazine.com/
| background-color: transparent !important; | ||
| } | ||
| div#overlay-MENU_AS_CONTAINER, | ||
| div[data-testid="page-bg"] { |
There was a problem hiding this comment.
Background area in the articles occasionally showing white:
https://www.thrivemagazine.com/single-post/the-best-plant-based-eats-in-miami
There was a problem hiding this comment.
div[data-testid="page-bg"] will break background on main (home page) I started testing it without this and started to look fine.
There was a problem hiding this comment.
https://www.thrivemagazine.com/single-post/the-best-plant-based-eats-in-miami
Additional I had this white background you mentioned one time. Then I could not reproduce but the white part was inside iframe:
Maybe it would be easier to use iframe as selector instead. 😅
There was a problem hiding this comment.
I just found a solution for this.
I will make a proposal.
| div[data-testid="page-bg"] { | ||
| background-color: var(--darkreader-background-ffffff, #000000) !important; | ||
| } | ||
| div[data-testid="screenWidthContainerBgCenter"] { |
There was a problem hiding this comment.
Area in the center of the footer occasionally showing light green:
https://www.thrivemagazine.com/
There was a problem hiding this comment.
I additionally found one more popup which had two buttons transparent. So my whole fix would be:
thrivemagazine.com
INVERT
div#MENU_AS_CONTAINER_TOGGLE span
CSS
nav#MENU_AS_CONTAINER_EXPANDABLE_MENU *,
div#MENU_AS_CONTAINER_TOGGLE > div {
background-color: transparent !important;
}
div#overlay-MENU_AS_CONTAINER,
iframe,
a.wixui-button:not(:hover) {
background-color: var(--darkreader-neutral-background) !important;
}
div[data-testid="screenWidthContainerBgCenter"] {
background-color: initial !important;
}
You can check it and apply to your PR. If it would work for you. 😉
Then comment I can do rereview.
| div.wixui-vertical-menu__arrow svg { | ||
| fill: var(--darkreader-neutral-text) !important; | ||
| } | ||
| nav#MENU_AS_CONTAINER_EXPANDABLE_MENU a { |
There was a problem hiding this comment.
I can not confirm that applying this is needed. I see light text in dark scheme and dark in light scheme without this CSS fix. Checked both Firefox and Edge.
| div#MENU_AS_CONTAINER_TOGGLE span | ||
|
|
||
| CSS | ||
| div.wixui-vertical-menu__arrow svg { |
There was a problem hiding this comment.
Checked in Firefox and Edge... I don't see any need for this entry. Without it I have visible arrow.
| background-color: transparent !important; | ||
| } | ||
| div#overlay-MENU_AS_CONTAINER, | ||
| div[data-testid="page-bg"] { |
There was a problem hiding this comment.
div[data-testid="page-bg"] will break background on main (home page) I started testing it without this and started to look fine.
| } | ||
| div#overlay-MENU_AS_CONTAINER, | ||
| div[data-testid="page-bg"] { | ||
| background-color: var(--darkreader-background-ffffff, #000000) !important; |
There was a problem hiding this comment.
I would use background-color: var(--darkreader-neutral-background) !important; instead.
| background-color: transparent !important; | ||
| } | ||
| div#overlay-MENU_AS_CONTAINER, | ||
| div[data-testid="page-bg"] { |
There was a problem hiding this comment.
https://www.thrivemagazine.com/single-post/the-best-plant-based-eats-in-miami
Additional I had this white background you mentioned one time. Then I could not reproduce but the white part was inside iframe:
Maybe it would be easier to use iframe as selector instead. 😅
Myshor
left a comment
There was a problem hiding this comment.
Changed to Request Changes.
|
Please wait three to four hours. Thank you. |
The purpose is to define the color of pagination numbers and icons on the following pages: https://www.thrivemagazine.com/breakfast https://www.thrivemagazine.com/savory-recipes https://www.thrivemagazine.com/vegan-desserts while excluding the following page: https://www.thrivemagazine.com/wellness The first three pages have a wow-image element while the fourth does not. We also use: div[data-hook="post-list-root"]:not(.lte-post_content_area_small) in order to exclude the mobile version of any of the pages.
|
The solution was to set transparent background on div[data-testid="page-bg"]. |




https://www.thrivemagazine.com/