Skip to content

Add dynamic theme fixes for thrivemagazine.com - #15870

Open
arturstat wants to merge 3 commits into
darkreader:mainfrom
arturstat:patch-11854
Open

Add dynamic theme fixes for thrivemagazine.com#15870
arturstat wants to merge 3 commits into
darkreader:mainfrom
arturstat:patch-11854

Conversation

@arturstat

Copy link
Copy Markdown
Contributor

@arturstat
arturstat marked this pull request as draft August 14, 2026 02:51
thrivemagazine.com

INVERT
div#MENU_AS_CONTAINER_TOGGLE span

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hamburguer icon in the mobile version:
https://www.thrivemagazine.com/

div#MENU_AS_CONTAINER_TOGGLE span

CSS
div.wixui-vertical-menu__arrow svg {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up and down arrow icon in the sidepanel:
https://www.thrivemagazine.com/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in Firefox and Edge... I don't see any need for this entry. Without it I have visible arrow.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the arrow is visible.
However, it is still not clear enough for me.
Please see the comment below.

div.wixui-vertical-menu__arrow svg {
fill: var(--darkreader-neutral-text) !important;
}
nav#MENU_AS_CONTAINER_EXPANDABLE_MENU a {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text in the sidepanel:
https://www.thrivemagazine.com/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not confirm that applying this is needed. I see light text in dark scheme and dark in light scheme without this CSS fix. Checked both Firefox and Edge.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is visible, but I suggest making it brighter for improved visibility.
Maybe we all have different eyes!
In fact, I use contrast at +35 and maybe that is why I need this fix.

Image

This is how it looks with the proposed fixes.

Image

nav#MENU_AS_CONTAINER_EXPANDABLE_MENU a {
color: var(--darkreader-neutral-text) !important;
}
nav#MENU_AS_CONTAINER_EXPANDABLE_MENU *,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Area in the sidepanel that sometimes is green instead of black:
https://www.thrivemagazine.com/

color: var(--darkreader-neutral-text) !important;
}
nav#MENU_AS_CONTAINER_EXPANDABLE_MENU *,
div#MENU_AS_CONTAINER_TOGGLE > div {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Area around the hamburguer icon in the mobile version occasionally showing green:
https://www.thrivemagazine.com/

div#MENU_AS_CONTAINER_TOGGLE > div {
background-color: transparent !important;
}
div#overlay-MENU_AS_CONTAINER,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Area in the sidepanel occasionally showing green:
https://www.thrivemagazine.com/

Comment thread src/config/dynamic-theme-fixes.config Outdated
background-color: transparent !important;
}
div#overlay-MENU_AS_CONTAINER,
div[data-testid="page-bg"] {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Background area in the articles occasionally showing white:
https://www.thrivemagazine.com/single-post/the-best-plant-based-eats-in-miami

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

div[data-testid="page-bg"] will break background on main (home page) I started testing it without this and started to look fine.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.thrivemagazine.com/single-post/the-best-plant-based-eats-in-miami

Additional I had this white background you mentioned one time. Then I could not reproduce but the white part was inside iframe:

Image

Maybe it would be easier to use iframe as selector instead. 😅

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I see without div[data-testid="page-bg"] and with iframe instead.

Screenshot_15-8-2026_11927_www thrivemagazine com

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found a solution for this.
I will make a proposal.

div[data-testid="page-bg"] {
background-color: var(--darkreader-background-ffffff, #000000) !important;
}
div[data-testid="screenWidthContainerBgCenter"] {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Area in the center of the footer occasionally showing light green:
https://www.thrivemagazine.com/

@arturstat
arturstat marked this pull request as ready for review August 14, 2026 02:59

@Myshor Myshor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I additionally found one more popup which had two buttons transparent. So my whole fix would be:

thrivemagazine.com

INVERT
div#MENU_AS_CONTAINER_TOGGLE span

CSS
nav#MENU_AS_CONTAINER_EXPANDABLE_MENU *,
div#MENU_AS_CONTAINER_TOGGLE > div {
    background-color: transparent !important;
}
div#overlay-MENU_AS_CONTAINER,
iframe,
a.wixui-button:not(:hover) {
    background-color: var(--darkreader-neutral-background) !important;
}
div[data-testid="screenWidthContainerBgCenter"] {
    background-color: initial !important;
}

The popup preview after fix:
obraz

You can check it and apply to your PR. If it would work for you. 😉

Then comment I can do rereview.

div.wixui-vertical-menu__arrow svg {
fill: var(--darkreader-neutral-text) !important;
}
nav#MENU_AS_CONTAINER_EXPANDABLE_MENU a {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not confirm that applying this is needed. I see light text in dark scheme and dark in light scheme without this CSS fix. Checked both Firefox and Edge.

div#MENU_AS_CONTAINER_TOGGLE span

CSS
div.wixui-vertical-menu__arrow svg {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in Firefox and Edge... I don't see any need for this entry. Without it I have visible arrow.

Comment thread src/config/dynamic-theme-fixes.config Outdated
background-color: transparent !important;
}
div#overlay-MENU_AS_CONTAINER,
div[data-testid="page-bg"] {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

div[data-testid="page-bg"] will break background on main (home page) I started testing it without this and started to look fine.

Comment thread src/config/dynamic-theme-fixes.config Outdated
}
div#overlay-MENU_AS_CONTAINER,
div[data-testid="page-bg"] {
background-color: var(--darkreader-background-ffffff, #000000) !important;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use background-color: var(--darkreader-neutral-background) !important; instead.

@arturstat arturstat Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree!

Comment thread src/config/dynamic-theme-fixes.config Outdated
background-color: transparent !important;
}
div#overlay-MENU_AS_CONTAINER,
div[data-testid="page-bg"] {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.thrivemagazine.com/single-post/the-best-plant-based-eats-in-miami

Additional I had this white background you mentioned one time. Then I could not reproduce but the white part was inside iframe:

Image

Maybe it would be easier to use iframe as selector instead. 😅

@Myshor Myshor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to Request Changes.

@arturstat

Copy link
Copy Markdown
Contributor Author

Please wait three to four hours. Thank you.

The purpose is to define the color of pagination numbers and icons on the following pages:

https://www.thrivemagazine.com/breakfast
https://www.thrivemagazine.com/savory-recipes
https://www.thrivemagazine.com/vegan-desserts

while excluding the following page:

https://www.thrivemagazine.com/wellness

The first three pages have a wow-image element while the fourth does not. We also use:
div[data-hook="post-list-root"]:not(.lte-post_content_area_small)
in order to exclude the mobile version of any of the pages.
@arturstat

Copy link
Copy Markdown
Contributor Author

The solution was to set transparent background on div[data-testid="page-bg"].
The original color of the pagination numbers and icons on the pages with a background image was restored.
Please check.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants