Fixed orteil.dashnet.org homepage#15121
Draft
johnnycharlesw wants to merge 1 commit into
Draft
Conversation
alexanderby
requested changes
Mar 17, 2026
|
|
||
| ================================ | ||
|
|
||
| orteil.dashnet.org |
Member
There was a problem hiding this comment.
The fixes should be sorted alphabetically
|
|
||
| CSS | ||
| html { | ||
| background-color:#5d00a8; |
Member
There was a problem hiding this comment.
Leave a space after ":" and use "!important" in the end to force the values.
| background-image:url(shadedEdges.png),url(bg.png); | ||
| background-size:100% 100%,auto; | ||
| } | ||
| CSS |
Member
There was a problem hiding this comment.
Remove repeated CSS keyword.
| } | ||
| CSS | ||
| #firstBox,#Wgames,#Wtoys,#Wexps,#Wlinks | ||
| { |
Member
There was a problem hiding this comment.
The opening brace should be on the same line as the last selector (separated with space).
Collaborator
|
I tried to apply this "fix" after adding I bet someone is trying to apply background like original: I am with big no... but as @alexanderby you started to review this then consider if we want to merge or just reject. |
Author
|
Well, I tried...I'll just keep it in my fork until it is ready, I guess... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I just added in a rule to fix the homepage of
orteil.dashnet.org, I tested it, it does not break Cookie Clicker it seems.