Fix for various#14783
Draft
06kellyjac wants to merge 13 commits into
Draft
Conversation
Only the hosted chats, the zulip.com website doesn't have themes.
Disabling darkreader fixes some of their tooling e.g. Path of Exile builds.
Make mobile hamburger visible. Make eBPF logo more visible. Make text for main button more visible. Make tick marks more visible.
Not perfect since the default theme is defined in CSS by the user preferences, but it's not worse than current. It means that darkreader will start enabled but will be turned off as needed when the user switches theme.
Initial theme is decided by OS preferences and specified with a theme of "dark light", but darkreader can identify and skip opt-in dark mode.
Also accounts for where set to device and selects into dark.
Author
Member
|
Please separate the PRs, and only supply a fix where it's really necessary. I couldn't reproduce the issues with the start page, it's probably fixed now. The react native issue doesn't seem to be related to HTML, but rather Android and iOS UI. |
Author
|
Thanks. Just to clarify slightly more complex css selectors like On startpage with "System default" it fails to recognize dark mode on 4.9.112. I can check again for latest 
It looks like explicit dark and night work fine. Shall I remove those hints and just keep what's needed for System Default to work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startpage.comdeveloper.mozilla.orgopentitan.orgsupabase.comebpf.iomaxroll.ggto dark sitesandroid-x86.orgdocs.renovatebot.com*.zulipchat.comexpo.devgist.github.comdeveloper.hashicorp.comzen-browser.appI've tested all but
*.zulipchat.comin a fresh zen-browser. That one I've tested by hand withdocument.querySelector()I'll log in to a chat at some point tomorrow.
The auto detection for
opentitan.orgmostly works but it can get stuck as "detected dark mode" on light mode until refreshed. Lightmode to darkmode is identified properly without refreshing.Auto detection for startpage is a bit odd since it can set 2 different default colours when using
device. I couldn't find something fixed to use.There aren't any other css selectors using
:hasor:notso I'll keep this draft to discuss in-case that's not allowedI can also split this out into separate PRs if necessary but I wanted to get a discussion going in one place first :)