Skip to content

Fix detector hint for www.youtube.com #14617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix detector hint for www.youtube.com #14617

wants to merge 2 commits into from

Conversation

@lumynou5
Copy link
Contributor

@lumynou5 lumynou5 commented Sep 3, 2025

No description provided.

alexanderby
alexanderby requested changes Sep 3, 2025
View reviewed changes
src/config/detector-hints.config Outdated
MATCH
[dark]

IFRAME
Copy link
Member

@alexanderby alexanderby Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please tell if this is necessary? If it's for the studio subdomain only, maybe it's worth moving it to a separate section?

Copy link
Contributor Author

@lumynou5 lumynou5 Sep 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that embeded live chat (www.youtube.com domain) is not detected as expected if you turn off and on Dark Reader.

Though I didn't find out why Dark Reader doesn't mis-enable without restarting, it behaves correctly if it's not an iframe. Therefore, I thought the reason is something stops the detection (I initially thought it's the mismatched domain), and then I found

darkreader/src/background/extension.ts

Lines 702 to 707 in 6c9edf3

const detectDarkTheme = (
settings.detectDarkTheme &&
(isTopFrame || detectorHints?.some((h) => h.iframe)) &&
!isURLInList(tabURL, settings.enabledFor) &&
!isPDF(tabURL)
);

If the hint doesn't allow iframes, the detector is not run on iframes:

darkreader/src/inject/index.ts

Lines 135 to 142 in 6c9edf3

if (detectDarkTheme) {
runDarkThemeDetector((hasDarkTheme) => {
if (hasDarkTheme) {
removeDynamicTheme();
onDarkThemeDetected();
}
}, detectorHints);
}

See also: #10765

Copy link
Contributor Author

@lumynou5 lumynou5 Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I understand the code correctly?

Copy link
Member

@alexanderby alexanderby Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark theme is usually detected on root frames. But some websites use fullscreen iframes, that's why this IFRAME is needed. Could you please share a screenshon without a fix, so that I better understand the context?

Copy link
Contributor Author

@lumynou5 lumynou5 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected:
the live chat is normal

Actual:
the live chat is dark-ized

@lumynou5 lumynou5 requested a review from alexanderby October 7, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexanderby alexanderby Awaiting requested review from alexanderby

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lumynou5 @alexanderby