Support for transparent backgrounds #14560
Conversation
…cy as not to effect rest of page
|
Now it is in a usable state |
|
First of all... If you add new variable into localization it should be added into all languages as it can break the functionality of Dark Reader when used with other language than English. The rest I can not comment as I am not that much involved in other places of Dark Reader's code. |
|
Let me think what's the best way to implement in. |
I added some placeholder text so it won't break in other languages, but definitely do need somebody else to do the actual translation (Unless you want me to use ai or something) |
|
Currently my biggest issue is some sites just seem to ignore the transparency. I suspect that the issue is sites setting their own theme. But other than that, I feel this is functional. |
3 participants
Added an optional feature to add transparency to the background color. (As requested in #14199, #13017, and a few others)
Still has some kinks to work out (Most sites look awful), and transparency (To my knowledge) only seems to be supported in the Zen browser. Because of that, I hid the feature behind an "Enable background transparency" setting in the advanced options. As of now, it is functional, however has some graphical issue.
To enable transparency in the zen browser, you need to set the following in your
about:config:I opened this PR to gather feedback, what do you all think of this, does this deserve up in the upstream package or should I keep it as a fork?
Ps: This is my first time writing typescript, or code for a browser extension, so feedback is greatly appreciated!
Pps: This image below also has some userChrome.css modifications and the Transparent Zen mod.