Skip to content

Conversation

@Adrien-LUDWIG
Copy link

Fix unsupported rgba of hex color var causing box-shadow to disappear

Fix unsupported rgba of hex color var
@Myshor
Copy link
Collaborator

Myshor commented Feb 25, 2025

Can you share some URL to test it before merge? I just want to be sure the fix is working fine in both kind of browsers - Chromium based and Firefox.

@Myshor
Copy link
Collaborator

Myshor commented Feb 25, 2025

Nevermind I found it by myself - used this URL to test: https://exercism.org/tracks/java/concepts

This fix works fine in Firefox but then it breaks the page in Chromium based browsers.

As you started the fix I will push fix that works fine in all browsers to your branch and then merge. 😉

Use original variable that works fine in all browsers.
@Adrien-LUDWIG
Copy link
Author

Adrien-LUDWIG commented Feb 26, 2025

Thank you very much for the tests and fix!
I only checked caniuse.com because I don't usually a Chromium based browser. I'll take this into account next time. 😉

This is not perfect, the bottom gradient color doesn't match the next section (class "tabs") color, but I don't know how to make it better.
@Adrien-LUDWIG Adrien-LUDWIG marked this pull request as draft February 26, 2025 23:49
@Adrien-LUDWIG
Copy link
Author

I discovered some more things to fix so I made this a draft PR. I'll resume it once I'm finished.

@Adrien-LUDWIG Adrien-LUDWIG marked this pull request as ready for review April 30, 2025 07:10
@Adrien-LUDWIG
Copy link
Author

Adrien-LUDWIG commented Apr 30, 2025

Oops, looks like I forgot to mark the PR as ready! Sorry for the delay.

Added one selector for black logo to invert.
@Myshor
Copy link
Collaborator

Myshor commented Apr 30, 2025

Added one more selector to INVERTs and merging. 😉

@Adrien-LUDWIG
Copy link
Author

Thanks again for your help @Myshor! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants