-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix for exercism.org #13959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix for exercism.org #13959
Conversation
Fix unsupported rgba of hex color var
|
Can you share some URL to test it before merge? I just want to be sure the fix is working fine in both kind of browsers - Chromium based and Firefox. |
|
Nevermind I found it by myself - used this URL to test: https://exercism.org/tracks/java/concepts This fix works fine in Firefox but then it breaks the page in Chromium based browsers. As you started the fix I will push fix that works fine in all browsers to your branch and then merge. 😉 |
Use original variable that works fine in all browsers.
|
Thank you very much for the tests and fix! |
This is not perfect, the bottom gradient color doesn't match the next section (class "tabs") color, but I don't know how to make it better.
See: https://exercism.org/journey (need to be logged in)
|
I discovered some more things to fix so I made this a draft PR. I'll resume it once I'm finished. |
|
Oops, looks like I forgot to mark the PR as ready! Sorry for the delay. |
Added one selector for black logo to invert.
|
Added one more selector to INVERTs and merging. 😉 |
|
Thanks again for your help @Myshor! 😉 |
Fix unsupported rgba of hex color var causing box-shadow to disappear