Repository navigation
Replies: 6 comments 2 replies
|
This option is to get latest sites fixes from config folder in this repo. For some sites like github and/or google which uses system-prefence to check and include difference in site code only when you manually force dark theme in their setting our detection hints will work when correct part of code is found for dark mode. Summarizing: You test on exactly 2 pages that doesn't make differences for dark theme in html code. |
|
My Themes are set to dark mode in Google and Github and dark reader still does not detect it correctly. On github it isn't to bad, just see some minor differences in boxes and layout but on google its noticeable. When first doing a search on google.com, I'll see brown boarders and other times it will flash and change appearance once dark mode is detected. This is the same behavior on virustotals dark mode, the other things I've noticed with these sites is the page is much slower to load as it tries to detect dark mode. |
|
I checked the current source for this option. The "remote server" is GitHub raw content from:
So the option updates Dark Reader's own site-specific rules between extension releases. It does not force GitHub, Google, VirusTotal, etc. to use their native dark theme, and it does not guarantee that native dark-theme detection will work for every site state. For your GitHub/Google case, it sounds more like a site-specific detection-hint issue than the sync option itself. Useful details for a bug report would be:
That should make it easier to decide whether |
|
For github you must force single theme and then some of the dark themes. Regarding Google (and others using similar methods): they often use Currently, detection-hints in Dark Reader are designed to check classes or attributes on the Since Google doesn't change the DOM structure when switching between light and dark modes (relying only on CSS media queries or that ambiguous meta tag), there is currently no reliable way to support it via the standard configuration file without major changes to the extension's core detection logic. Additionally, I checked how the "Detect dark theme" option works with Google without any detection-hints added, and it works perfectly fine in my Firefox. As you can see on the screenshot below, Dark Reader correctly identifies the native dark mode ("Dark theme detected on page") and works as intended. 😋 |
|
I've set the theme on github to single theme and used the default dark theme and its still not consistent, if i go to a new github page then dark mode is detected but if I go to a page that is in my history like the main page to github.com it still fails to detect dark mode. The page loads slower as well when compared to manually adding it to the list. With Google dark theme is detected but there is a quick flash between when the page loads and when dark mode is detcted, this flash is very quick so i cant get a screenshot but you can see the theme page. |
Detection settings doesn't work on older tabs that was already opened. If you want to check them if detection works for them you will need to refresh them.
With that flashes we can not do anything. Dark Reader checking the site when it's fully loaded (or at least the main code is loaded if the site is loading some elements dynamically). It works the same for applying Dark Reader changes. Bigger sites can be white for a while before Dark Reader applies it changes. |
|
Here are screenshots of 1 second as the screen flashes and dark reader detects the dark theme. This is the same behavior on github and virustotal. I am using Brave, but it is the same in Edge. |
|
Check my answer above. |
Uh oh!
There was an error while loading. Please reload this page.
I haven't been able to figure out what this option does, I assume it applies fixes to sites outside the extension. Where is the 'remote server' it uses to get the 'fixes'?
I enabled it and it still cannot detect dark mode properly for github or google, only way to use the sites dark mode is to add it to my list manually.
All reactions