How can I prevent injection of darkreader--font-fix styles in documentPicturePicture window (in Chrome or other Chromium browsers) #15236
-
|
I'm having an issue where dark reader is injecting To reproduce:
const btn = document.createElement('button');
btn.textContent = "Show window";
document.body.appendChild(btn);
btn.addEventListener('click', async () => {
const pipWin = await documentPictureInPicture.requestWindow();
const darkReaderLock = document.createElement("meta");
darkReaderLock.name = "darkreader-lock";
pipWin.document.head.appendChild(darkReaderLock);
});
btn.click();
<html>
<head>
<meta name="darkreader-lock">
<style class="darkreader darkreader--font-fix">...</style>
</head>
<body></body>
</html>Is there some other way to prevent these styles from being added? Or am I going about this the wrong way... |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 5 replies
-
|
Small question. As I understand I need some spotify installed or something? I tried to reproduce and nothing happened afer running script in console. |
Beta Was this translation helpful? Give feedback.
-
|
No, the scripts just appends a button at the bottom of the page, you might need to scroll down to see it. You do need Chrome 116 (Release date: 2023-08-15) or check the compatibility table for edit: Added |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for more details. I am using Firefox as my Default browser so the script (even with Tried in MS Edge and it opened some window. |
Beta Was this translation helpful? Give feedback.
-
|
According to the compatibility table it seems you need a preview version of Firefox for |
Beta Was this translation helpful? Give feedback.
-
|
I am not sure if it would be possible. Dark Reader is designed to work with main site (tab/window) but... I will call @alexanderby - main Dark Reader developer. If there is some solution to your scenario it's biggest chance he will know it. 😉 |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the way to reproduce the issue. Indeed there was a bug in cleaning up the style, and no support for the meta tag, since picture-in-picture is a separate document. Fixed just now, so expect the patch in 1-2 weeks. |
Beta Was this translation helpful? Give feedback.
-
|
awesome, thank you! linking 4429aaa for completeness |
Beta Was this translation helpful? Give feedback.
Thank you for the way to reproduce the issue. Indeed there was a bug in cleaning up the style, and no support for the meta tag, since picture-in-picture is a separate document. Fixed just now, so expect the patch in 1-2 weeks.