#16 workaround#17
Merged
Merged
Conversation
daquinoaldo
force-pushed
the
#16-workaround
branch
from
3c90ff5 to
e080d9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Fix an error that can occur due to an undefined value of
req.headers["host"]on express.js.Since a fix is not possible, we provided a workaround that fixes the bug on localhost. This script should run only on localhost as developing support, hence this workaround shouldn't cause problems (and in any case prevent a brutal crash).
Related Issue
#16
Types of changes