Adds a deprecation warning for the wait() method #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
- Coverage 86.37% 86.28% -0.09%
==========================================
Files 79 82 +3
Lines 4094 4172 +78
==========================================
+ Hits 3536 3600 +64
- Misses 558 572 +14 ☔ View full report in Codecov by Sentry. |
berndverst
approved these changes
Mar 6, 2024
berndverst
pushed a commit
to berndverst/python-sdk
that referenced
this pull request
Mar 6, 2024
* Adds a deprecation warning for the wait() method Signed-off-by: Elena Kolevska <elena@kolevska.com> * Ruff Signed-off-by: Elena Kolevska <elena@kolevska.com> --------- Signed-off-by: Elena Kolevska <elena@kolevska.com>
berndverst
added a commit
that referenced
this pull request
Mar 6, 2024
* Adds a deprecation warning for the wait() method (#682) * Adds a deprecation warning for the wait() method Signed-off-by: Elena Kolevska <elena@kolevska.com> * Ruff Signed-off-by: Elena Kolevska <elena@kolevska.com> --------- Signed-off-by: Elena Kolevska <elena@kolevska.com> * Release Python SDK 1.13.0 Signed-off-by: Bernd Verst <github@bernd.dev> --------- Signed-off-by: Elena Kolevska <elena@kolevska.com> Signed-off-by: Bernd Verst <github@bernd.dev> Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
elena-kolevska
added a commit
to elena-kolevska/python-sdk
that referenced
this pull request
Apr 24, 2024
* Adds a deprecation warning for the wait() method Signed-off-by: Elena Kolevska <elena@kolevska.com> * Ruff Signed-off-by: Elena Kolevska <elena@kolevska.com> --------- Signed-off-by: Elena Kolevska <elena@kolevska.com>
berndverst
added a commit
that referenced
this pull request
Jun 27, 2024
* Brings back the link we removed because it wasn’t online yet Signed-off-by: Elena Kolevska <elena@kolevska.com> * Retry decorator Signed-off-by: Elena Kolevska <elena@kolevska.com> * Use a retry function instead of a decorator Signed-off-by: Elena Kolevska <elena@kolevska.com> * adds retries for async Signed-off-by: Elena Kolevska <elena@kolevska.com> * Fixes types Signed-off-by: Elena Kolevska <elena@kolevska.com> * Timeout policy Signed-off-by: Elena Kolevska <elena@kolevska.com> * Cleanup Signed-off-by: Elena Kolevska <elena@kolevska.com> * retry for http wip. Signed-off-by: Elena Kolevska <elena@kolevska.com> * tests for http retries Signed-off-by: Elena Kolevska <elena@kolevska.com> * New ruff version has some formatting changes Signed-off-by: Elena Kolevska <elena@kolevska.com> * Revert "New ruff version has some formatting changes" This reverts commit 8609b7f. Signed-off-by: Elena Kolevska <elena@kolevska.com> * Fixes setting values with a default of None Signed-off-by: Elena Kolevska <elena@kolevska.com> * Moves timeout Signed-off-by: Elena Kolevska <elena@kolevska.com> * Adds a deprecation warning for the wait() method (#682) * Adds a deprecation warning for the wait() method Signed-off-by: Elena Kolevska <elena@kolevska.com> * Ruff Signed-off-by: Elena Kolevska <elena@kolevska.com> --------- Signed-off-by: Elena Kolevska <elena@kolevska.com> * Pin ruff version Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Elena Kolevska <elena@kolevska.com> * Pin ruff version in tox.ini Signed-off-by: Bernd Verst <github@bernd.dev> Signed-off-by: Elena Kolevska <elena@kolevska.com> * Lint fix Signed-off-by: Elena Kolevska <elena@kolevska.com> * Reorganises tests. Adds retry for actors. Signed-off-by: Elena Kolevska <elena@kolevska.com> * Linters Signed-off-by: Elena Kolevska <elena@kolevska.com> * Retry all calls Signed-off-by: Elena Kolevska <elena@kolevska.com> * Small fix and docs update Signed-off-by: Elena Kolevska <elena@kolevska.com> * Adds a note to docs, for clarity Signed-off-by: Elena Kolevska <elena@kolevska.com> --------- Signed-off-by: Elena Kolevska <elena@kolevska.com> Signed-off-by: Bernd Verst <github@bernd.dev> Co-authored-by: Bernd Verst <github@bernd.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a deprecation warning for the wait() method