Reject max_attempts=None in RetryPolicy instead of crashing - #1212
Open
magic-peach wants to merge 1 commit into
Open
Reject max_attempts=None in RetryPolicy instead of crashing#1212magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
The constructor's type hint allows max_attempts to be None, but the validation compared it directly against -1, raising an unhelpful TypeError instead of the same ValueError every other invalid value gets. Now None is rejected with the same clear message. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RetryPolicy's constructor types max_attempts as Optional[int], but the validation compared it directly against -1, so RetryPolicy(max_attempts=None) raised an unhelpful TypeError instead of the same ValueError every other invalid constructor argument gets. settings.DAPR_API_MAX_RETRIES, the actual default, can never itself become None at runtime, so this only affects a caller who explicitly passes None, which the type hint invites. Fixed with a one line guard.
Issue reference
Please reference the issue this PR will close: N/A, self-discovered while reviewing dapr/clients/retry.py, no existing issue filed.
Checklist