Stop fire_reminder crashing on a non-dict payload - #1211
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
The code deserializes the reminder request body then only builds reminder_data when it is a dict, with a comment saying to ignore it otherwise, but invoke_reminder always referenced reminder_data regardless, so a non-dict payload like JSON null raised a NameError instead of being ignored. Now returns early before building the closure when the payload is not a dict. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code deserializes the reminder request body then only builds reminder_data when it is a dict, with a comment saying to ignore it otherwise, but invoke_reminder always referenced reminder_data regardless, so a non-dict payload like JSON null raised a NameError instead of being ignored. Now returns early before building the closure when the payload is not a dict.
Issue reference
No existing issue tracks this; found while reviewing the actor reminder dispatch path.
Checklist