Add template to bump - #410
Closed
dappnodedev wants to merge 5 commits into
Closed
Conversation
This was
linked to
issues
Mar 25, 2024
dappnodedev
force-pushed
the
dappnodedev/add-template-to-bump
branch
from
March 25, 2024 10:20
be5de55 to
68dac9c
Compare
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: b79f137 This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
Marketen
reviewed
Mar 25, 2024
| manifestFileName?: string; | ||
| }): VariantManifestMap { | ||
| const variantsMap: VariantManifestMap = {}; | ||
| const fullVariantsDirPath = path.join(dir, variantsDir); |
Contributor
There was a problem hiding this comment.
should dir and variantsDir be somewhat sanitized so that fullVariantsDirPath is correctly built? It is crucial that it is a correct path
Contributor
Author
There was a problem hiding this comment.
Actually if the path is empty or it does not exist it will either throw an error (caught in the parent function) or return an empty array so there will be no variants to modify. I'd say this is enough
Contributor
Author
|
Overridden by #418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
bumpaction to edit manifest and compose files of a template package repository