Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna need more context about why you want this implemented since AFAIK this will not work for your desires. Please create an issue with details and link it to this PR. However I don't think this will help, and regardless will need to be undone during a coming refactor with internal IP addresses and we are moving off of the subnet you added since its a public IP block. Please make an issue https://github.com/dappnode/DAppNodePackage-bitcoin/issues and explain in more detail your issue because just allowing the ip range wont help since you need to have an exposed port to the host. not to the internal docker network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I also expose the port in the network settings via the dappnode gui (on the package's port settings page)
I am doing this because I need a connection to the bitcoin rpc port that is reliable for multiple days. I have always had trouble having uninterrupted connections to both the dappnode vpn as well as the dappnode wifi. (In the first case, my vpn connection will occasionally fail, and in the second case, the wifi stops being connected to the internet)
So instead of being on the vpn or dappnode wifi, I just stay on my normal wifi (which uses the normal 192.168.0.0/24 subnet) and assign my dappnode a private static ip address via my home router.
Here's my config sparrow config:
(the proxy config is irrelevant here)
I think that if you are going to set this to something other than
0.0.0.0/0then you should allow the user to override the configuration. In that case you just need to add the environment variable to the docker-compose fileUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one still breaks compatibility with other packages like LN I think need confirm from @tropicar also if you're on the same LAN this is unnecessary. Just forward the RPC port to the host from the docker container. You can then point it at the forwarded RPC port on the dappnode using the DAppNodes LAN address. You don't need to use a VPN or the dappnode Wi-Fi to connect like that if the port is properly exposed to the host. No need for proxies and changing the code of the package. I know I said this before but don't think I was particularly clear about VPNs and Wi-Fi not being needed. Just reserve an IP on your LAN and set it to your dappnode so it keeps the same local IP much simpler.