(Dale et al. 2007) like inverse ray tracing method for HII regions and cleanup#814
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the HII region feedback module, introducing an inverse ray tracing algorithm and updating the equation of state to manage ionization states through temperature and molecular weight thresholds. The changes also include integration with the derivative calculation step and new test setups. Review feedback identifies several critical issues, including a compilation error due to a missing OpenMP shared variable, a bug in smoothing length assignment, and a race condition in parallel source updates. Further improvements are needed regarding the neighbor cache size, the physical accuracy of boundary interpolation, and the initialization of the overlap array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I implemented the inverse ray-tracing method to compute the Strömgren volume of a massive star (in Jim Dale's series of papers). It has been hanging on a branch for a few months now. I had to do some cleanup for my PhD, and I think it is finally ready to merge. This new method is not a replacement for the old one. Both can be chosen by changing the
iH2Rvariable.-First, there is a major rework of the arrays used for the method. I removed the
isionisedarray, which was unnecessary, and used eos_vars instead.-The ray tracing method has been added in
h2region.f90and is now accessible withiH2R=2. The ray tracer is very similar to the one used inutils_raytracer.f90. It might be helpful to abstract the methods in this one to use it for this purpose. Probably a big work though...-Every call of
HII_feedbackroutine has been relocated inderivsjust beforecons2prim, where it should have been since the beginning.I had a massive merge conflict since my branch was quite old... I did my best to resolve it without breaking anything. I'm hoping the tests will find my mistakes if I made any.
Components modified:
Type of change:
Testing:
See above
Did you run the bots? yes
Did you update relevant documentation in the docs directory? no
Did you add comments such that the purpose of the code is understandable? yes
Is there a unit test that could be added for this feature/bug? yes