Added ability to pause the program

DonJayamanne · DonJayamanne · commit 183bfd22349a · 2016-02-08T14:58:48.000+11:00
diff --git a/src/client/debugger/vs/PythonProcess.ts b/src/client/debugger/vs/PythonProcess.ts
@@ -74,6 +74,7 @@ export class PythonProcess extends EventEmitter implements IPythonProcess {
         this.callbackHandler.on("detach", () => this.emit("detach"));
         this.callbackHandler.on("last", () => this.emit("last"));
         this.callbackHandler.on("moduleLoaded", arg=> this.emit("moduleLoaded", arg));
+        this.callbackHandler.on("asyncBreakCompleted", arg=> this.emit("asyncBreakCompleted", arg));
         this.callbackHandler.on("threadCreated", arg=> this.emit("threadCreated", arg));
         this.callbackHandler.on("threadExited", arg=> this.emit("threadExited", arg));
         this.callbackHandler.on("stepCompleted", arg=> this.onPythonStepCompleted(arg));
@@ -250,7 +251,9 @@ export class PythonProcess extends EventEmitter implements IPythonProcess {
     public SendClearStepping(threadId: number) {
 
     }
-
+    public Break() {
+        this.stream.Write(Commands.BreakAllCommandBytes);
+    }
     public ExecuteText(text: string, reprKind: PythonEvaluationResultReprKind, stackFrame: IPythonStackFrame): Promise<IPythonEvaluationResult> {
         return new Promise<IPythonEvaluationResult>((resolve, reject) => {
             var executeId = this._idDispenser.Allocate();
diff --git a/src/client/debugger/vs/PythonProcessCallbackHandler.ts b/src/client/debugger/vs/PythonProcessCallbackHandler.ts
@@ -45,6 +45,7 @@ export class PythonProcessCallbackHandler extends EventEmitter {
             case "EXCP": this.HandleException(); break;
             case "EXCR": this.HandleExecutionResult(); break;
             case "EXCE": this.HandleExecutionException(); break;
+            case "ASBR": this.HandleAsyncBreak(); break;
             default: {
                 console.error("Uhandled command = " + cmd);
                 this.emit("error", `Unhandled command '${cmd}'`);
@@ -152,6 +153,17 @@ export class PythonProcessCallbackHandler extends EventEmitter {
         }
         this.emit("stepCompleted", pyThread);
     }
+    private HandleAsyncBreak() {
+        var threadId = this.stream.ReadInt64();
+        if (this.stream.HasInsufficientDataForReading) {
+            return;
+        }
+        var pyThread: IPythonThread;
+        if (this.process.Threads.has(threadId)) {
+            pyThread = this.process.Threads.get(threadId);
+        }
+        this.emit("asyncBreakCompleted", pyThread);
+    }
     private HandleBreakPointFailed() {
         var id = this.stream.ReadInt32();
         if (this.stream.HasInsufficientDataForReading) {
diff --git a/src/client/debugger/vs/VSDebugger.ts b/src/client/debugger/vs/VSDebugger.ts
@@ -149,6 +149,7 @@ class PythonDebugSession extends DebugSession {
         this.pythonProcess.on("breakpointHit", (pyThread, breakpointId) => this.onBreakpointHit(pyThread, breakpointId));
         this.pythonProcess.on("detach", () => this.onDetachDebugger());
         this.pythonProcess.on("error", ex => this.sendEvent(new OutputEvent(ex, "stderr")));
+        this.pythonProcess.on("asyncBreakCompleted", arg=> this.onPythonProcessPaused(arg));
     }
     private onDetachDebugger() {
         this.stopDebugServer();
@@ -166,6 +167,9 @@ class PythonDebugSession extends DebugSession {
     private onPythonThreadExited(pyThread: IPythonThread) {
         this.sendEvent(new ThreadEvent("exited", pyThread.Id));
     }
+    private onPythonProcessPaused(pyThread: IPythonThread) {
+        this.sendEvent(new StoppedEvent("pause", pyThread.Id));
+    }
     private onPythonModuleLoaded(module: IPythonModule) {
     }
     private onPythonProcessLoaded(pyThread: IPythonThread) {
@@ -490,8 +494,8 @@ class PythonDebugSession extends DebugSession {
     }
             
     protected pauseRequest(response: DebugProtocol.PauseResponse): void {
-        console.error('Not yet implemented: pauseRequest');
-        this.sendErrorResponse(response, 2000, "Pause is not yet supported");
+        this.pythonProcess.Break();
+        this.sendResponse(response);        
     }
 
     protected setExceptionBreakPointsRequest(response: DebugProtocol.SetExceptionBreakpointsResponse, args: DebugProtocol.SetExceptionBreakpointsArguments): void {

Original file line number	Diff line number	Diff line change
`@@ -149,6 +149,7 @@ class PythonDebugSession extends DebugSession {`
`149`	`149`	`this.pythonProcess.on("breakpointHit", (pyThread, breakpointId) => this.onBreakpointHit(pyThread, breakpointId));`
`150`	`150`	`this.pythonProcess.on("detach", () => this.onDetachDebugger());`
`151`	`151`	`this.pythonProcess.on("error", ex => this.sendEvent(new OutputEvent(ex, "stderr")));`
	`152`	`+ this.pythonProcess.on("asyncBreakCompleted", arg=> this.onPythonProcessPaused(arg));`
`152`	`153`	`}`
`153`	`154`	`private onDetachDebugger() {`
`154`	`155`	`this.stopDebugServer();`
`@@ -166,6 +167,9 @@ class PythonDebugSession extends DebugSession {`
`166`	`167`	`private onPythonThreadExited(pyThread: IPythonThread) {`
`167`	`168`	`this.sendEvent(new ThreadEvent("exited", pyThread.Id));`
`168`	`169`	`}`
	`170`	`+ private onPythonProcessPaused(pyThread: IPythonThread) {`
	`171`	`+ this.sendEvent(new StoppedEvent("pause", pyThread.Id));`
	`172`	`+ }`
`169`	`173`	`private onPythonModuleLoaded(module: IPythonModule) {`
`170`	`174`	`}`
`171`	`175`	`private onPythonProcessLoaded(pyThread: IPythonThread) {`
`@@ -490,8 +494,8 @@ class PythonDebugSession extends DebugSession {`
`490`	`494`	`}`
`491`	`495`
`492`	`496`	`protected pauseRequest(response: DebugProtocol.PauseResponse): void {`
`493`		`- console.error('Not yet implemented: pauseRequest');`
`494`		`- this.sendErrorResponse(response, 2000, "Pause is not yet supported");`
	`497`	`+ this.pythonProcess.Break();`
	`498`	`+ this.sendResponse(response);`
`495`	`499`	`}`
`496`	`500`
`497`	`501`	`protected setExceptionBreakPointsRequest(response: DebugProtocol.SetExceptionBreakpointsResponse, args: DebugProtocol.SetExceptionBreakpointsArguments): void {`