Repository navigation
Conversation
A client's Query fields live in a module the engine has not served yet, so the first query would fail. AbstractClient::serve sends serveModule once per target and per client instance, and does not record a failed serve, so the next call retries. --client now takes --address and --pin, and generates Client as a final class of static methods. Each one serves its target on the shared Dagger::getClientInstance() before it starts the query, so a core Directory passes into a client call. The e2e check calls a client of a local module and of a pinned Git module. The Git daemon helper leaves the Git-source check so both use it. Client types have no load<Type>FromID loaders in the beta.25 view, so only the entry methods serve. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
client-target-loading
branch
from
November 11, 2026 14:31
eeadd22 to
bc27f8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #25. Second part of the unified-clients work (no user-visible change yet).
Dagger\\Client\\ModuleTargetandAbstractClient::serve()sendserveModule(address, refPin)once per target and per client instance (a failed serve is retried).--clientnow takes--addressand--pinand generatesDagger\\Clients\\<Name>\\Clientas a final class of static methods; each one serves its target on the sharedDagger::getClientInstance()before it starts the query, so a coreDirectorypasses into a client call. Client types have noload<Type>FromIDloaders in the beta.25 view, so only the entry methods serve.Checks, on the beta.27 engine and CLI:
sdk-codegen-unit-checkpassed (30 tests);sdk-unit-checkpassed with a temporary wider filter (185 tests); newclient-target-call-checkpassed: it calls a client of a local module and of a Git module at a pin (the pin is proved by movingmainafterwards).generated-entrypoint-call-checkfails before its Git half at the assertion fixed by #14, so the extracted Git helpers are proved by the new check instead.Not proved:
generateScopeintegration, Composer autoload of clients in a module, a target declaring beta.26 or later, a real public Git remote.