Repository navigation
Conversation
The engine's PHP runtime seeds the template into a module without composer.json, so the blocker only kept such modules on the runtime. Generation now seeds it, and new modules take the same path. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
entrypoint-seed-composer
branch
from
November 11, 2026 14:31
683c96d to
b12a31e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the previous pull request. A module without
composer.jsonstayed on the PHP runtime, although that runtime seeds the starter template itself. Generation now seeds the template under the module's own files (existing files win), the 'no composer.json' blocker is gone, andrenderedTemplatemoved fromPhpSdkintoModbecause onlyModknows the module name on a directmod(). Behaviour change inmodule init: a scope that already has acomposer.jsonkeeps it and gets no starter files (now asserted). Therootingfixture ofgenerate-existing-module-checkmoves to the entrypoint.Checks, on the beta.27 engine and CLI:
entrypoint-migration-check,generate-existing-module-checkandentrypoint-ownership-checkpassed (the existing-module check was served from cache after an earlier run). Not proved: calling a seeded module (generated-entrypoint-call-checknot run).