Repository navigation
Conversation
Migration would silently drop a manifest engineVersion later than the target, a version the SDK cannot generate for. A module already on the entrypoint is not refused: the engine reads its dang.toml version. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
entrypoint-guard-engine-version
branch
from
November 11, 2026 14:31
dc0f07d to
cc9083d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the previous pull request. Migration drops a manifest
engineVersion, which would move a module created by a newer CLI back across the identifier-casing cut. A manifestengineVersionlater thantargetEngineVersionnow keeps the module on the runtime. A module already on the entrypoint is not refused: the engine reads such a module's version fromdang.toml, not from the manifest (engine v1.0.0-beta.27,resolveModuleSourceVersions). The test uses v1.1.0, so it holds for both the current and the beta.27 target.Checks, on the beta.27 engine and CLI:
entrypoint-migration-check,target-version-checkandentrypoint-ownership-checkpassed. Not proved: thedagger.jsonreading path with a later version.