Repository navigation
Conversation
A version 2 manifest ignores these keys, so migration silently turned caching on or dropped the clients. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
entrypoint-guard-caching
branch
from
November 11, 2026 14:31
427c4da to
ad4170c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to the generated entrypoint (
usesEntrypoint) now keeps a module on the PHP runtime when it setsdisableDefaultFunctionCaching: trueor recordsclients: a version 2 manifest ignores both keys, so migration silently turned caching on or dropped the clients. A module already on the entrypoint with either setting is refused through the existing branch. README lists the new reasons.Checks, on the beta.27 engine and CLI:
entrypoint-migration-check(three new assertions and one refusal) andentrypoint-ownership-checkpassed. Not proved: aclientsentry in a realdagger.json; observing a migrated module's caching.