Repository navigation
Conversation
This was referenced Nov 11, 2026
The engine attributes client types with `@sourceMap(module:)`. Core generation skips them, and each client generates into `Dagger\Clients\<Name>`. A client can only add fields to `Query`. `.client-module` lets regeneration tell the same client from a case variant; the caller may replace it with a list check later. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
codegen-partition
branch
from
November 11, 2026 14:31
99e7e9b to
13e96a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of the unified-clients work (design: row 6 part 1; no user-visible change). The codegen reads
@sourceMap(module:)on types and fields:--core(the default) generates the types no module owns, exactly as today;--client <module>generates only that module's types intogenerated/Clients/<Name>/in the namespaceDagger\\Clients\\<Name>, naming core types under\\Dagger\\. Refusals: a client name equal to another client's ignoring case (an ownership marker file lets the same client regenerate), a field contributed to a type other thanQuery, a name PHP reserves. Four vendored codegen files change;sdk/VENDOR.mdlists them.Checks, on the beta.27 engine and CLI: new
sdk-codegen-unit-checkpassed (27 tests, 93 assertions, no engine needed);sdk-unit-checkpassed with a temporary wider filter (201 tests). Locally in a throwaway container,--coreand the default path on a real 149-type engine schema produced the same 136 files, byte for byte, asmain's codegen on that schema with its one module removed.Not proved: that the engine serves such a schema, that a client call works, or that Composer loads the generated client (later parts).