Repository navigation
Conversation
The engine owns enum member names from v1.0.0-beta.26. The generate exec needs DAGGER_CLIENT_VERSION and privileged nesting to ask it. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
enum-naming-engine
branch
from
November 11, 2026 14:30
17700d8 to
3818170
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #12, fixes the gap #12 documents. For a target of v1.0.0-beta.26 or later, the enum collision check asks the engine for member names (
Query.naming(version).module(name).enumMemberNames) instead of the copied pre-beta.26 rules. The generate exec getsDAGGER_CLIENT_VERSIONand privileged nesting to ask it. Targets below beta.26, and engines without thenamingAPI, keep the earlier rules. The README and the two docblocks no longer describe a gap.Checks, on the beta.27 engine and CLI:
sdk-unit-checkpassed with a real run (177 tests, 275 assertions);entrypoint-migration-checkpassed on the first revision with a new case (Base64/BASE64refused with the engine's names; the later revision changed only an assertion message).Not proved: the fallback on an engine below beta.26; that the engine itself drops the duplicate.