Repository navigation
Conversation
The engine passes scope settings only to generateScope, so a direct mod generated for the default release. WorkspaceSDK.scopeSetting is beta.26+ view only, below php-sdk's beta.17 engineVersion, so mod reads dagger.toml. Only targetVersion records are checked here; the engine validates the rest. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
target-consistency
branch
from
November 11, 2026 14:30
57a85f1 to
50f620c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #12. When no
targetVersionis passed,modreads thetargetVersionthatdagger.tomlrecords for the module's scope (same lookup rules as the engine at v1.0.0-beta.27 and as python-sdk), with the same refusals as an explicit setting. Precedence: explicit setting, then recorded target, then the default. Path-equivalent scope keys match; ambiguoustargetVersionrecords and keys that escape the workspace are refused. The engine'sscopeSettingfield is not used: it exists only in beta.26+ views, and this module'sengineVersionis beta.17.One difference from
dagger generate: there the record wins over[modules.php-sdk.settings]; inmoda passed setting wins (documented in the README).Checks, on the beta.27 engine and CLI:
target-version-checkpassed (new assertions: recorded pin, later pin refused, explicit wins, other scope ignored, path-equivalent pin, conflicting keys, escaping key);entrypoint-config-checkpassed on the first revision (generateScopeis unchanged). Not asserted: case-colliding names, two SDK entries for one module.