Repository navigation
Conversation
Dagger\ maps to both src/ and generated/; --strict-ambiguous catches a class defined in both. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
composer-check
branch
from
November 11, 2026 14:31
b76a307 to
009e538
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #19. Adds an e2e
sdk-composer-check:composer validate --strict,composer install(which enforces the lock's platform requirements), then codegen andcomposer dump-autoload --classmap-authoritative --strict-psr --strict-ambiguousoversrc/,generated/,tests/and the unit fixture.--strict-ambiguousis there becauseDagger\\maps to bothsrc/andgenerated/. No existing violation, so no source changed.Check, on the beta.27 engine and CLI:
sdk-composer-checkfails on a class in the wrong namespace (psr-4 error) and passes on the final tree (3000 classes). It runs on PHP 8.4, so it does not check the library's>=8.2floor.