Repository navigation
Conversation
src references the generated client, so codegen runs before analysis. PHP's default 128M memory limit crashes PHPStan; the peak is 389 MB. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
phpstan-level5
branch
from
November 11, 2026 14:31
23fc90b to
cef5c17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #17. Adds
sdk/phpstan.dist.neon(level 5 oversdk/srcandsdk/tests/Unit/Module) and an e2esdk-analysis-check. The two errors PHPStan finds, both in vendoredsrc/Client/files, are recorded in a baseline copied verbatim from dagger/daggersdk/php(identical at beta.25 and beta.27); no source changed.Check, on the beta.27 engine and CLI:
sdk-analysis-checkfails on a deliberate type error and passes on the final tree ([OK] No errors).