Repository navigation
Conversation
Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
up-function-role
branch
from
November 11, 2026 14:30
0da5454 to
a4a5fb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #16. A
#[Up]attribute marks a function the engine can run as a service, emitted as.withUplike#[Generate]is as.withGenerator. Validation follows the engine's beta.27 rule (validateUpFunction,core/module.go): the function returns a non-nullServiceand requires no argument except aWorkspace. The e2e fixture getsselfUp(), andgenerated-entrypoint-call-checkassertsdagger start -llists it (upis a hidden alias ofstart).Checks, on the beta.27 engine and CLI:
sdk-unit-checkpassed with a temporary filter includingDaggerFunctionTest(202 tests, 321 assertions; the repo's filter does not include it, #13 widens it).generated-entrypoint-call-checkpassed every assertion up to its last one, which fails onmainon beta.27 (fixed in #14).Not proved:
dagger startactually runningselfUp.