Repository navigation
Conversation
This was referenced Nov 11, 2026
The exec still fails, so the engine does not cache it and a retry runs the function again; an exec with expect: ANY would replay the failure. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
entrypoint-error-propagation
branch
from
November 11, 2026 14:30
60cc17a to
bdeaf20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On engine beta.27 a failed exec's error message carries only
exit code: 1, so a PHP function's error no longer reached the caller andgenerated-entrypoint-call-checkfails onmain(and on #11, #12, #13). The generated entrypoint now catches the exec's error and raises the stderr from itsextensions(the engine caps it at 100 KiB), re-raising the original error when there is none. The exec keeps the defaultexpect, so a failed exec is not cached and a retry runs again.Checks, on the beta.27 engine and CLI:
generated-entrypoint-call-checkpassed (it failed onmain);sdk-unit-checkandentrypoint-config-checkpassed on an earlier revision of this change (the final revision reran the call check; unit run could not be shown to execute PHPUnit).