Repository navigation
Conversation
This was referenced Nov 11, 2026
The vendored library changes only version.php: upstream sdk/php differs between v1.0.0-beta.25 and v1.0.0-beta.27 only in generated/ and version.php. The e2e pins move, and the later-release refusal now uses v1.0.0-beta.28. The enum collision check still follows the naming before the cut. Signed-off-by: Yves Brissaud <yves@dagger.io>
eunomie
force-pushed
the
target-beta27
branch
from
November 11, 2026 14:30
bddefcf to
0f17129
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the PHP SDK's target engine version from v1.0.0-beta.25 to v1.0.0-beta.27:
targetEngineVersion,version.php, README,VENDOR.md, and the e2e pins.targetVersionand its refusals are unchanged; the accepted range is now beta.17 to beta.27. The generator and the vendored library need no change (upstreamsdk/phpdiffers only ingenerated/andversion.php).Known gap, documented in the README and
EngineNaming: the enum collision check still follows the naming rules from before beta.26. Fixing it is a separate change.Checks, all on the beta.27 engine and CLI:
target-version-checkandgenerate-new-module-checkpassed (target-version-on-target-checkdoes not exist);entrypoint-config-checkpassed (on the amended commit).generated-entrypoint-call-checkfails on this branch and on cleanmainalike (the engine's failed-exec error no longer carries the PHP message); the fix is a separate change.