E2e workspace - #13
Merged
Merged
Conversation
That way the main workspace remains clean. Signed-off-by: Yves Brissaud <yves@dagger.io>
TomChv
added a commit
to dagger/typescript-sdk
that referenced
this pull request
Aug 7, 2026
Ports dagger/java-sdk#13: the repository's dagger.toml registered this SDK against the e2e fixture modules and the fixture client, so the real workspace advertised test fixtures as managed. That registration moves to a test-only dagger.toml under the fixtures directory, reached through Fixtures.workspace. Incomplete — pushed for discussion, not for merge. discovery:* passes. generate:* and client:* cannot work as written, because codegen needs the session's client-backed workspace and the fixtures config can only be selected by a synthetic one: - asWorkspace(cwd:) re-runs config detection, so the nested dagger.toml is selected, but the workspace carries no client ID and ModuleSource.generateLocalDependencies (mod.dang:97, added in #12) fails in withWorkspaceClientContext. - Workspace.withWorkdir keeps the client but only clones and sets Cwd, so ConfigFile stays the repository's dagger.toml and currentModule.asSDK(ws) reports the SDK is not installed. Codegen then resolves "typescript" to the builtin SDK rather than this one, which passes for the wrong reason. java-sdk does not hit this: its Mod.generate reads only introspectionSchemaJSON and builds the generated files in its own container, so a synthetic workspace is enough. Unblocking here needs an engine change — withWorkdir re-detecting config, or generateLocalDependencies working on a synthetic workspace. Signed-off-by: Tom Chauveau <tom@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.