Implement "unified" lookup mechanism for module state #7237
+101
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is that all lookups for the module state go through `__PYX_GET_MODULE_STATE()` and the code generation no longer needs to care about what type of lookup it might be (so doesn't need to know anything about the scope). At the start of each function we create a temporary definition for __PYX_GET_MODULE_STATE() using one of a number of mechanisms depending on what information is available in the scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that all lookups for the module state go through
__PYX_GET_MODULE_STATE()and the code generation no longer needs to care about what type of lookup it might be (so doesn't need to know anything about the scope).At the start of each function we create a temporary definition for __PYX_GET_MODULE_STATE() using one of a number of mechanisms depending on what information is available in the scope.
The is very much a draft - I've only tested that it compiled on a single file so I complete expect it to fail. It's more a request for comments on the general approach.