Improve deduction of const in templates #7234
Conversation
* Arguments passed by value don't add deduce as "const". * `const T` with `const int` now evaluates `T` as `int` * If we've deduced the type of two arguments "the same except that one is const" then that's not considered compatible (and we use the more restricted const type). Fixes cython#6294
|
I've tagged this as 3.3 just to avoid the temptation to hold up 3.2 for it. |
There was a problem hiding this comment.
Instead of adding an option is_value_type and passing that through all the methods, we could have a second method deduce_template_params_for_value_type() that calls deduce_template_type() by default and can be overwritten separately.
Which do you find better?
|
I mildly prefer the version I have here - I think if we added a new call to However - either version would work so it's not something I feel particularly strongly about if you'd rather change it. I think this should be left to 3.3 though - a lot of the C++ template stuff can be a bit fragile so it's probably a bit risky to merge now. Although obviously I'd be happy to have it reviewed and ready to go for when that's safely branched off. |
2 participants
const Twithconst intnow evaluatesTasintFixes #6294