fix(devtool): recover when app sinks arrive late - #1031
Open
jamilahmadzai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #436.
What changed
@cycle/runhook to provide compatible xstream sinks after the inspected app finishes booting.Root cause
The extension probes the inspected page after 50 ms. When the app has not exposed sinks yet, that probe starts the serializer with
nulland sets the globalstartedflag. The later call from@cycle/runthen returns early even though it contains the real app sinks.User impact
Apps that initialize after the extension's first probe can now replace the initial no-app state with their actual dataflow graph. Existing behavior is preserved for incompatible sinks, repeated probes, and serializers that have already started successfully.
Validation
npm --prefix devtool run test-ci— passesgit diff --check— passesThe DevTool's full legacy lint and TypeScript build remain blocked by pre-existing violations and dependency declaration incompatibilities in the package. The new helper itself compiles under the repository's pinned TypeScript 3.2.4 compiler, and it introduces no new lint findings.