Split time controls re-designed #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual games Use the new TimeControlWidget in support of TimeControlDialog. Enable second TimeControlWidget for Black on demand. Add timeControl2 to GameSettingsWidget, save/read settings for 2nd control. Add extra control logic for hourglass mode. GUI: Option to use individual time controls in tournaments Add a context menu to the tournament players' list. Add function to edit time controls individually. Use a simplified time control dialog (2nd time control unused). Add QVector of individual time controls to NewTournamentDialog. Support multi-engine selection for time control updates. Use an individual time control when valid else tournament controls. At tournament creation hourglass mode is enabled or disabled uniformly according to the tournament's common settings.
artoj
reviewed
Jul 20, 2024
Member
Author
|
I'll fix the array offset thing, if I can confirm that there's a bug in Cute Chess code. I'll also fix the dialog types for |
Member
|
LGTM |
artoj
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-designed the UI and re-factored some of the code for pull 599, i.e. split time controls. This also includes and thus replaces, everything in pull 599.