Re-use previous tournament's settings #706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not delete NewTournamentDialog after usage, but re-use it for the next tournament. Add reset functionality to NewTournamentDialog. Only values read from .ini-file are restored. Simplify and correct NewTournamentDialog::readSettings. Resolves cutechess#209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the usage of the
NewTournamentDialogin the GUI. Currently this dialog is deleted after use (OK or Cancel) and a new instance with the default settings is used for the next tournament.This code re-uses the existing
NewTournamentDialogwith old values to speed up the set-up of the next - probably similar - tournament. A new Reset-Button triggers the reset to values originating from the settings in the file cutechess.ini . However, other values which have no setting in cutechess.ini remain unchanged.The method
NewTournamentDialog::readSettingshas been simplified and corrected.This PR is an alternative to the patch which uses a new dialog after reset, PR #707.
Resolves #209
A "Reset"-button has been added to NewTournamentDialog.
Example: Values before ...
... and after pressing the "Reset"-button.
HTH.