Skip to content

Add notes to engine configurations #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alwey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add notes to engine configurations #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions projects/gui/src/engineconfigurationdlg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ void EngineConfigurationDialog::applyEngineInformation(
ui->m_protocolCombo->setCurrentIndex(i);

ui->m_initStringEdit->setPlainText(engine.initStrings().join("\n"));
ui->m_notesEdit->setPlainText(engine.notes());

if (engine.whiteEvalPov())
ui->m_whitePovCheck->setCheckState(Qt::Checked);
Expand Down Expand Up @@ -149,6 +150,8 @@ EngineConfiguration EngineConfigurationDialog::engineConfiguration()
if (!initStr.isEmpty())
engine.setInitStrings(initStr.split('\n'));

engine.setNotes(ui->m_notesEdit->toPlainText());

engine.setWhiteEvalPov(ui->m_whitePovCheck->checkState() == Qt::Checked);

QList<EngineOption*> optionCopies;
Expand Down
14 changes: 12 additions & 2 deletions projects/gui/ui/engineconfigdlg.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<x>0</x>
<y>0</y>
<width>480</width>
<height>400</height>
<height>500</height>
</rect>
</property>
<layout class="QVBoxLayout" name="verticalLayout_3">
Expand Down Expand Up @@ -118,7 +118,7 @@
</property>
</widget>
</item>
<item row="5" column="1">
<item row="6" column="1">
<widget class="QCheckBox" name="m_whitePovCheck">
<property name="enabled">
<bool>false</bool>
Expand All @@ -131,6 +131,16 @@
</property>
</widget>
</item>
<item row="5" column="1">
<widget class="QPlainTextEdit" name="m_notesEdit"/>
</item>
<item row="5" column="0">
<widget class="QLabel" name="m_notesLabel">
<property name="text">
<string>Notes:</string>
</property>
</widget>
</item>
</layout>
</widget>
<widget class="QWidget" name="tab_2">
Expand Down
19 changes: 19 additions & 0 deletions projects/lib/src/engineconfiguration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ EngineConfiguration::EngineConfiguration(const QVariant& variant)
addOption(option);
}
}

if(map.contains("notes"))
setNotes(map["notes"].toString());
}

EngineConfiguration::EngineConfiguration(const EngineConfiguration& other)
Expand All @@ -103,6 +106,7 @@ EngineConfiguration::EngineConfiguration(const EngineConfiguration& other)
m_workingDirectory(other.m_workingDirectory),
m_stderrFile(other.m_stderrFile),
m_protocol(other.m_protocol),
m_notes(other.m_notes),
m_arguments(other.m_arguments),
m_initStrings(other.m_initStrings),
m_variants(other.m_variants),
Expand All @@ -127,6 +131,7 @@ EngineConfiguration& EngineConfiguration::operator=(EngineConfiguration&& other)
m_workingDirectory = other.m_workingDirectory;
m_stderrFile = other.m_stderrFile;
m_protocol = other.m_protocol;
m_notes = other.m_notes;
m_arguments = other.m_arguments;
m_initStrings = other.m_initStrings;
m_variants = other.m_variants;
Expand Down Expand Up @@ -183,6 +188,9 @@ QVariant EngineConfiguration::toVariant() const
map.insert("options", optionsList);
}

if(!m_notes.isEmpty())
map.insert("notes", m_notes);

return map;
}

Expand Down Expand Up @@ -361,6 +369,16 @@ void EngineConfiguration::setClaimsValidated(bool validate)
m_validateClaims = validate;
}

QString EngineConfiguration::notes() const
{
return m_notes;
}

void EngineConfiguration::setNotes(const QString thenotes)
{
m_notes = thenotes;
}

EngineConfiguration& EngineConfiguration::operator=(const EngineConfiguration& other)
{
if (this != &other)
Expand All @@ -370,6 +388,7 @@ EngineConfiguration& EngineConfiguration::operator=(const EngineConfiguration& o
m_workingDirectory = other.m_workingDirectory;
m_stderrFile = other.m_stderrFile;
m_protocol = other.m_protocol;
m_notes = other.m_notes;
m_arguments = other.m_arguments;
m_initStrings = other.m_initStrings;
m_variants = other.m_variants;
Expand Down
5 changes: 5 additions & 0 deletions projects/lib/src/engineconfiguration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,10 @@ class LIB_EXPORT EngineConfiguration
/*! Sets result claim validation mode to \a validate. */
void setClaimsValidated(bool validate);

/*! Returns the notes regarding the engine. */
QString notes() const;
/*! Sets notes regarding the engine. */
void setNotes(const QString thenotes);
/*!
* Assigns \a other to this engine configuration and returns
* a reference to this object.
Expand All @@ -218,6 +222,7 @@ class LIB_EXPORT EngineConfiguration
QString m_workingDirectory;
QString m_stderrFile;
QString m_protocol;
QString m_notes;
QStringList m_arguments;
QStringList m_initStrings;
QStringList m_variants;
Expand Down