Skip to content

Issue warning if a UCI engine sends a PV when not supposed to do this #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alwey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue warning if a UCI engine sends a PV when not supposed to do this #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
If a UCI engine sends a PV when not supposed to be in the thinking state 
or pondering, then issue a warning.
  • Loading branch information
@alwey
alwey committed Dec 31, 2021
commit f4585b73df8b2e76eb50bc0df59a632408d11ec2
8 changes: 7 additions & 1 deletion projects/lib/src/uciengine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,13 @@ void UciEngine::parseInfo(const QVarLengthArray<QStringRef>& tokens,
eval->setPvNumber(tokens[0].toString().toInt());
break;
case InfoPv:
eval->setPv(m_useDirectPv ? directPv(tokens) : sanPv(tokens));
if (this->state() == Thinking
|| (this->state() == Observing && pondering()))
eval->setPv(m_useDirectPv ? directPv(tokens) : sanPv(tokens));
else if (this->state() != FinishingGame)
qWarning("Unexpected PV from %s: %s",
qUtf8Printable(name()),
qUtf8Printable(directPv(tokens)));
break;
case InfoScore:
{
Expand Down