Corrections after debugging

alwey · alwey · commit 717798197184 · 2022-01-26T02:29:46.000+01:00
diff --git a/projects/gui/src/engineconfigurationdlg.cpp b/projects/gui/src/engineconfigurationdlg.cpp
@@ -348,10 +348,10 @@ void EngineConfigurationDialog::onEngineQuit()
 			if (isVisible())
 				QMessageBox::critical(this, tr("Engine Error"),
 						      m_engine->errorString());
+			emit hasError();
 		}
 		m_engine->deleteLater();
 		m_engine = nullptr;
-		emit hasError();
 	}
 
 	ui->m_detectBtn->setEnabled(true);
diff --git a/projects/gui/src/enginemanagementwidget.cpp b/projects/gui/src/enginemanagementwidget.cpp
@@ -230,7 +230,6 @@ void EngineManagementWidget::detectEngine(const QString& file,
 		EngineConfigurationDialog::AddEngine, this);
 	dlg->setReservedNames(m_engineManager->engineNames());
 	dlg->setAttribute(Qt::WA_DeleteOnClose);
-	dlg->probe(file, proto);
 
 	connect(dlg, &EngineConfigurationDialog::finished, [=](int result)
 	{
@@ -244,12 +243,13 @@ void EngineManagementWidget::detectEngine(const QString& file,
 			m_hasChanged = true;
 			updateEngineCount();
 		}
-		dlg->close();
 	});
 	connect(dlg, &EngineConfigurationDialog::hasError, [=]()
 	{
-		dlg->reject();
+		dlg->close();
 	});
+
+	dlg->probe(file, proto);
 }
 
 void EngineManagementWidget::removeEngine()

Original file line number	Diff line number	Diff line change
`@@ -348,10 +348,10 @@ void EngineConfigurationDialog::onEngineQuit()`
`348`	`348`	`if (isVisible())`
`349`	`349`	`QMessageBox::critical(this, tr("Engine Error"),`
`350`	`350`	`m_engine->errorString());`
	`351`	`+ emit hasError();`
`351`	`352`	`}`
`352`	`353`	`m_engine->deleteLater();`
`353`	`354`	`m_engine = nullptr;`
`354`		`- emit hasError();`
`355`	`355`	`}`
`356`	`356`
`357`	`357`	`ui->m_detectBtn->setEnabled(true);`
Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,6 @@ void EngineManagementWidget::detectEngine(const QString& file,`
`230`	`230`	`EngineConfigurationDialog::AddEngine, this);`
`231`	`231`	`dlg->setReservedNames(m_engineManager->engineNames());`
`232`	`232`	`dlg->setAttribute(Qt::WA_DeleteOnClose);`
`233`		`- dlg->probe(file, proto);`
`234`	`233`
`235`	`234`	`connect(dlg, &EngineConfigurationDialog::finished, [=](int result)`
`236`	`235`	`{`
`@@ -244,12 +243,13 @@ void EngineManagementWidget::detectEngine(const QString& file,`
`244`	`243`	`m_hasChanged = true;`
`245`	`244`	`updateEngineCount();`
`246`	`245`	`}`
`247`		`- dlg->close();`
`248`	`246`	`});`
`249`	`247`	`connect(dlg, &EngineConfigurationDialog::hasError, [=]()`
`250`	`248`	`{`
`251`		`- dlg->reject();`
	`249`	`+ dlg->close();`
`252`	`250`	`});`
	`251`	`+`
	`252`	`+ dlg->probe(file, proto);`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`void EngineManagementWidget::removeEngine()`