fix modal dialog issues with time control dialogs

ilaripih · artoj · commit 456f99f3611b · 2024-07-21T12:18:35.000+03:00
diff --git a/projects/gui/src/gamesettingswidget.cpp b/projects/gui/src/gamesettingswidget.cpp
@@ -463,7 +463,8 @@ void GameSettingsWidget::showTimeControlDialog()
 	if (m_splitTimeControls)
 	{
 		PairTimeControlDialog dlg(m_timeControl[Chess::Side::White],
-				      m_splitTimeControls ? m_timeControl[Chess::Side::Black] : TimeControl());
+								  m_splitTimeControls ? m_timeControl[Chess::Side::Black] : TimeControl(),
+								  this->parentWidget());
 		if (dlg.exec() == QDialog::Accepted)
 		{
 			for (int i = 0; i < 2; i++)
@@ -474,7 +475,8 @@ void GameSettingsWidget::showTimeControlDialog()
 			accepted = true;
 		}
 	} else {
-		TimeControlDialog dlg(m_timeControl[Chess::Side::White]);
+		TimeControlDialog dlg(m_timeControl[Chess::Side::White],
+							  this->parentWidget());
 		if (dlg.exec() == QDialog::Accepted)
 		{
 			for (int i = 0; i < 2; i++)
diff --git a/projects/gui/src/newtournamentdialog.cpp b/projects/gui/src/newtournamentdialog.cpp
@@ -309,7 +309,7 @@ void NewTournamentDialog::onContextMenuRequest()
 		if (!tc.isValid())
 			tc = ui->m_gameSettings->timeControl();
 
-		auto dlg = new TimeControlDialog(tc);
+		auto dlg = new TimeControlDialog(tc, this);
 		QString name {m_addedEnginesManager->engines().at(i).name()};
 		if (selected.count() > 1)
 			name.append(tr(" - %0 engines").arg(selected.count()));
diff --git a/projects/gui/ui/pairtimecontroldlg.ui b/projects/gui/ui/pairtimecontroldlg.ui
@@ -11,9 +11,12 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Time Control</string>
+   <string>Time Controls</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="sizeConstraint">
+    <enum>QLayout::SetFixedSize</enum>
+   </property>
    <item>
     <layout class="QGridLayout" name="gridLayout">
      <property name="sizeConstraint">
diff --git a/projects/gui/ui/timecontroldlg.ui b/projects/gui/ui/timecontroldlg.ui
@@ -14,6 +14,9 @@
    <string>Time Control</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="sizeConstraint">
+    <enum>QLayout::SetFixedSize</enum>
+   </property>
    <item>
     <widget class="TimeControlWidget" name="m_timeControlWidget" native="true"/>
    </item>

Original file line number	Diff line number	Diff line change
`@@ -463,7 +463,8 @@ void GameSettingsWidget::showTimeControlDialog()`
`463`	`463`	`if (m_splitTimeControls)`
`464`	`464`	`{`
`465`	`465`	`PairTimeControlDialog dlg(m_timeControl[Chess::Side::White],`
`466`		`- m_splitTimeControls ? m_timeControl[Chess::Side::Black] : TimeControl());`
	`466`	`+ m_splitTimeControls ? m_timeControl[Chess::Side::Black] : TimeControl(),`
	`467`	`+ this->parentWidget());`
`467`	`468`	`if (dlg.exec() == QDialog::Accepted)`
`468`	`469`	`{`
`469`	`470`	`for (int i = 0; i < 2; i++)`
`@@ -474,7 +475,8 @@ void GameSettingsWidget::showTimeControlDialog()`
`474`	`475`	`accepted = true;`
`475`	`476`	`}`
`476`	`477`	`} else {`
`477`		`- TimeControlDialog dlg(m_timeControl[Chess::Side::White]);`
	`478`	`+ TimeControlDialog dlg(m_timeControl[Chess::Side::White],`
	`479`	`+ this->parentWidget());`
`478`	`480`	`if (dlg.exec() == QDialog::Accepted)`
`479`	`481`	`{`
`480`	`482`	`for (int i = 0; i < 2; i++)`