Open
Conversation
implement setState done callback
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 96.11% 95.23% -0.88%
==========================================
Files 1 1
Lines 103 105 +2
Branches 31 32 +1
==========================================
+ Hits 99 100 +1
- Misses 4 5 +1
Continue to review full report at Codecov.
|
Owner
|
Hey @CosticaPuntaru Thanks for raising this. Hmmm, interesting. Is it expected for the callbacks to be executed synchronously in a server rendering context? What is the default React behaviour around this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://reactjs.org/docs/react-component.html#setstate
react setState takes two parameters,
updaterandcallback. As i think the api should respect the react api i suggest to add callback to thesetStatefunction.