Skip to content

Commit 27710c5

Browse files
authored
fix(postcss-convert-values): preserve percent sign in length-percentage syntax (#1702)
1 parent b046d0b commit 27710c5

File tree

4 files changed

+22
-2
lines changed

4 files changed

+22
-2
lines changed

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,3 +73,4 @@ Thanks goes to these wonderful people:
7373
- Seth Falco
7474
- Seiya
7575
- Aleksandr Kondrashov
76+
- Jens Fosgerau

packages/postcss-convert-values/src/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,10 @@ function shouldKeepZeroUnit(decl, browsers) {
157157
(node) =>
158158
node.type === 'decl' &&
159159
node.prop.toLowerCase() === 'syntax' &&
160-
(node.value === "'<percentage>'" || node.value === '"<percentage>"')
160+
(node.value === "'<percentage>'" ||
161+
node.value === '"<percentage>"' ||
162+
node.value === "'<length-percentage>'" ||
163+
node.value === '"<length-percentage>"')
161164
)) ||
162165
keepWhenZero.has(lowerCasedProp)
163166
);

packages/postcss-convert-values/test/index.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,22 @@ test(
512512
)
513513
);
514514

515+
test(
516+
`should not strip the percentage from 0 in @property, for initial-value (length-percentage)`,
517+
processCSS(
518+
`@property --percent{syntax:'<length-percentage>';inherits:false;initial-value:0%;}`,
519+
`@property --percent{syntax:'<length-percentage>';inherits:false;initial-value:0%;}`
520+
)
521+
);
522+
523+
test(
524+
`should not strip the percentage from 0 in @property, for initial-value (length-percentage, syntax string in double quotes)`,
525+
processCSS(
526+
`@property --percent{syntax:"<length-percentage>";inherits:false;initial-value:0%;}`,
527+
`@property --percent{syntax:"<length-percentage>";inherits:false;initial-value:0%;}`
528+
)
529+
);
530+
515531
test(
516532
'should not strip the percentage from background-color',
517533
passthroughCSS('background-color:color-mix(#000, #FFF 0%);')

packages/postcss-convert-values/types/index.d.ts.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)