Module resolution improvements #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
reviewed
May 19, 2021
| @@ -1,4 +1,4 @@ | |||
| /** @type {import('@docusaurus/types').DocusaurusConfig} */ | |||
| /** @type {import('@docusaurus/core/lib').DocusaurusConfig} */ | |||
There was a problem hiding this comment.
is the problem due to not having @docusaurus/types in deps?
Owner
Author
There was a problem hiding this comment.
Yeah, so resolving @docusaurus/types will fail in e.g. yarn2 PnP, and it may fail with a node_modules directory depending on how the package manager chooses to set it up. The package manager isn't required to hoist in a particular way, or at all. It is only required to respect each package.json's declared dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.