Skip to content

tests: fix test_verify_assert_msg by setting Accept-Encoding #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csernazs merged 2 commits into from
Jul 21, 2024
Merged

tests: fix test_verify_assert_msg by setting Accept-Encoding #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdff40a
tests: fix test_verify_assert_msg by setting Accept-Encoding
csernazs Jul 20, 2024
bd240ba
tests: fix assert message comparison
csernazs Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions releasenotes/notes/fix-test_verify_assert_msg-af37678f187bb8da.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
Fix pytest-httpserver's own tests related to log querying. No functional
changes in pytest-httpserver code itself. `#345 <https://github.com/csernazs/pytest-httpserver/issues/345>`_
57 changes: 33 additions & 24 deletions tests/test_log_querying.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,39 +35,48 @@ def test_verify(httpserver: HTTPServer):
def test_verify_assert_msg(httpserver: HTTPServer):
httpserver.no_handler_status_code = 404
httpserver.expect_request("/foo", json={"foo": "bar"}, method="POST").respond_with_data("OK")
assert requests.get(httpserver.url_for("/foo"), headers={"User-Agent": "requests"}).status_code == 404
headers = {"User-Agent": "requests", "Accept-Encoding": "gzip, deflate"}
assert requests.get(httpserver.url_for("/foo"), headers=headers).status_code == 404

expected_lines = [
"Matching request found 0 times but expected 1 times.",
"Expected request: <RequestMatcher uri='/foo' method='POST' query_string=None headers={} data"
"=None json={'foo': 'bar'}>",
"Found 1 similar request(s):",
"--- Similar Request Start",
"Path: /foo",
"Method: GET",
"Body: b''",
f"Headers: Host: localhost:{httpserver.port}",
"User-Agent: requests",
"Accept-Encoding: gzip, deflate",
"Accept: */*",
"Connection: keep-alive",
"",
"",
"Query String: ''",
"--- Similar Request End",
]

with pytest.raises(AssertionError) as err:
httpserver.assert_request_made(RequestMatcher("/foo", json={"foo": "bar"}, method="POST"))

expected_message = f"""Matching request found 0 times but expected 1 times.
Expected request: <RequestMatcher uri='/foo' method='POST' query_string=None headers={{}} data=None json={{'foo': 'bar'}}>
Found 1 similar request(s):
--- Similar Request Start
Path: /foo
Method: GET
Body: b''
Headers: Host: localhost:{httpserver.port}\r
User-Agent: requests\r
Accept-Encoding: gzip, deflate\r
Accept: */*\r
Connection: keep-alive\r
\r

Query String: ''
--- Similar Request End
""" # noqa: E501
assert str(err.value) == expected_message
actual_lines = [x.strip() for x in str(err.value).splitlines()][: len(expected_lines)]
assert actual_lines == expected_lines


def test_verify_assert_msg_no_similar_requests(httpserver: HTTPServer):
httpserver.expect_request("/foo", json={"foo": "bar"}, method="POST").respond_with_data("OK")

expected_lines = [
"Matching request found 0 times but expected 1 times.",
"Expected request: <RequestMatcher uri='/foo' method='POST' query_string=None headers={} data"
"=None json={'foo': 'bar'}>",
"No similar requests found.",
]

with pytest.raises(AssertionError) as err:
httpserver.assert_request_made(RequestMatcher("/foo", json={"foo": "bar"}, method="POST"))

expected_message = """Matching request found 0 times but expected 1 times.
Expected request: <RequestMatcher uri='/foo' method='POST' query_string=None headers={} data=None json={'foo': 'bar'}>
No similar requests found.
"""
assert str(err.value) == expected_message
actual_lines = [x.strip() for x in str(err.value).splitlines()][: len(expected_lines)]
assert actual_lines == expected_lines