Skip to content

Commit 60f1063

Browse files
Paul m. p. Pdpgeorge
Paul m. p. P
authored and
dpgeorge
committed
py/runtime: Allow to override builtins.__import__ with Python func.
This patch adds a simple but powerful hook into the import system, in a CPython compatible way, by allowing to override builtins.__import__. This does introduce some overhead to all imports but it's minor: - the dict lookup of __import__ is bypassed if there are no modifications to the builtins module (which is the case at start up); - imports are not performance critical, usually done just at the start of a script; - compared to how much work is done in an import, looking up a value in a dict is a relatively small additional piece of work.
1 parent a8e3201 commit 60f1063

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

‎py/runtime.c‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1335,7 +1335,17 @@ mp_obj_t mp_import_name(qstr name, mp_obj_t fromlist, mp_obj_t level) {
13351335
args[3] = fromlist;
13361336
args[4] = level;
13371337

1338-
// TODO lookup __import__ and call that instead of going straight to builtin implementation
1338+
#if MICROPY_CAN_OVERRIDE_BUILTINS
1339+
// Lookup __import__ and call that if it exists
1340+
mp_obj_dict_t *bo_dict = MP_STATE_VM(mp_module_builtins_override_dict);
1341+
if (bo_dict != NULL) {
1342+
mp_map_elem_t *import = mp_map_lookup(&bo_dict->map, MP_OBJ_NEW_QSTR(MP_QSTR___import__), MP_MAP_LOOKUP);
1343+
if (import != NULL) {
1344+
return mp_call_function_n_kw(import->value, 5, 0, args);
1345+
}
1346+
}
1347+
#endif
1348+
13391349
return mp_builtin___import__(5, args);
13401350
}
13411351

0 commit comments

Comments
 (0)