Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

cmd/crossplane/rbac/rbac.go (1)

54-56: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win

Validate leader election timing constraints at startup.

The help text documents timing constraints (lease duration > renew deadline > retry period), but they're not enforced in code. Misconfigured values could cause unclear runtime errors.

Consider adding validation in the Run method before calling ctrl.NewManager:

if c.LeaderElection {
    if c.LeaderElectionRenewDeadline >= c.LeaderElectionLeaseDuration {
        return errors.New("leader election renew deadline must be less than lease duration")
    }
    if c.LeaderElectionRetryPeriod >= c.LeaderElectionRenewDeadline {
        return errors.New("leader election retry period must be less than renew deadline")
    }
}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/crossplane/rbac/rbac.go` around lines 54 - 56, Add runtime validation of
the leader election timing fields in the Run method: when LeaderElection is
true, check that LeaderElectionRenewDeadline < LeaderElectionLeaseDuration and
LeaderElectionRetryPeriod < LeaderElectionRenewDeadline, and return clear errors
if those constraints fail; update the Run function to perform these checks
before calling ctrl.NewManager, referencing the struct fields LeaderElection,
LeaderElectionLeaseDuration, LeaderElectionRenewDeadline, and
LeaderElectionRetryPeriod.

cmd/crossplane/core/core.go (1)

106-108: 🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win

Validate leader election timing constraints at startup.

The help text documents timing relationships (lease duration > renew deadline > retry period), but there's no validation to enforce these constraints. Misconfigured values could produce unclear runtime errors from controller-runtime.

Consider adding validation in the Run method before calling ctrl.NewManager:

if c.LeaderElection {
    if c.LeaderElectionRenewDeadline >= c.LeaderElectionLeaseDuration {
        return errors.New("leader election renew deadline must be less than lease duration")
    }
    if c.LeaderElectionRetryPeriod >= c.LeaderElectionRenewDeadline {
        return errors.New("leader election retry period must be less than renew deadline")
    }
}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/crossplane/core/core.go` around lines 106 - 108, Add startup validation
in the Run method to enforce the documented leader election timing constraints:
when LeaderElection is true, check that LeaderElectionRenewDeadline <
LeaderElectionLeaseDuration and LeaderElectionRetryPeriod <
LeaderElectionRenewDeadline and return descriptive errors if violated; reference
the fields LeaderElection, LeaderElectionLeaseDuration,
LeaderElectionRenewDeadline, LeaderElectionRetryPeriod and perform these checks
before calling ctrl.NewManager so misconfigurations fail fast with clear
messages.